Re: [PATCH 0/1] MR1660: mstask: Don't assume a ONCE trigger is on the current day.

[Sven Baars (＠sbaars)]

On Fri Dec  2 14:16:59 2022 +0000, **** wrote:
> Dmitry Timoshkov replied on the mailing list:
> ```
> Sven Baars <wine(a)gitlab.winehq.org> wrote:
> > -                if (CompareFileTime(&begin_ft, &trigger_ft) <= 0 &&
> > CompareFileTime(&trigger_ft, &end_ft) < 0)
> > +                if (CompareFileTime(&trigger_ft, ¤t_ft) >= 0)
> >                  {
> >                      if (!have_best_time ||
> > CompareFileTime(&trigger_ft, &best_ft) < 0)
> >                      {
> > Removing the trigger end time check doesn't look right.
> > -- 
> > Dmitry.
> Hi Dmitry,

Thanks for the reply. I don't see how begin_ft and end_ft are relevant for this trigger. It happens exactly once, at the "Start" time and "Begin" day. 

Having an "End" day before the "Begin" day is invalid for all triggers. I could add a patch that checks for that.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1660#note_18437