12 Oct
2023
12 Oct
'23
8:11 p.m.
On Wed Oct 11 10:37:15 2023 +0000, Giovanni Mascellani wrote:
Good to cleanup the node, but my feeling is that should be done at the same level it is initialized, i.e., inside `new_offset_from_path_index()`. To me keeping a consistent convention makes it easier to spot problems. Don't know what the others think about that. Another good option is to also initialize the block outside of `new_offset_from_path_index()`. This seems reasonable.
I prefer the latter option since otherwise we would have to call hlsl_block_cleanup() on every place where new_offset_from_path_index() returns NULL. I added a new patch 2 to the MR, since this is a prevailing issue. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/396#note_48564