12 Jan
2026
12 Jan
'26
7:55 p.m.
On Mon Jan 12 19:55:37 2026 +0000, Elizabeth Figura wrote:
``` - hr = asf_reader_stop_stream(filter); + if (filter->status == WMT_STARTED) + { + hr = asf_reader_stop_stream(filter); + should_start_stream = hr == S_OK; + } ``` If we failed to stop the stream shouldn't we just return failure?
i was trying to preserve the existing behavior, and i don't have enough context to know if early returning is appropriate. i can change it if you think that's what we should do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9858#note_126657