On Tue Jan 9 23:21:05 2024 +0000, Henri Verbeet wrote:
```diff + /** + * Binary format used by Direct3D 9/10.x/11 effects profiles. + * Output is a raw FX section without container. \since 1.10 + */ + VKD3D_SHADER_TARGET_FX, ```
That \since will need an update.
```diff + else if ((compile_info->target_type == VKD3D_SHADER_TARGET_FX) !=
(profile->type == VKD3D_SHADER_TYPE_EFFECT))
+ { + vkd3d_shader_error(message_context, NULL, VKD3D_SHADER_ERROR_HLSL_INCOMPATIBLE_PROFILE, + "The '%s' target profile is incompatible with the 'fx' target type.", profile->name); + return VKD3D_ERROR_INVALID_ARGUMENT; + } ``` I think the error message here is inaccurate when "target_type" isn't VKD3D_SHADER_TARGET_FX. Thanks. Both should be addressed now.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443#note_57049