Re: [PATCH 0/1] MR305: Draft: vkd3d-shader/hlsl: Implement strings

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.l:
> yylval->intval = vkd3d_parse_integer(yytext);
>                              return C_INTEGER;
>                          }
> +{STRING}                {
> +                            return STRING;
> +                        }

Our current STRING pattern is probably wrong for C strings; it forbids any backslashes inside the string. The preprocessor has a pattern which is probably more correct.

Adding an extra test or two here would not be a bad idea.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/305#note_42192