Re: [PATCH 0/10] MR9687: winebus, hidclass, dinput: Add bus_num and port_path to device_desc and use them in instance_id.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winebus.sys/main.c:
> if ((dst = ExAllocatePool(PagedPool, len * sizeof(WCHAR))))
>      {
> -        swprintf(dst, len, L"%u&%s&%x&%u&%u", ext->desc.version, ext->desc.serialnumber,
> -                 ext->desc.uid, ext->index, ext->desc.is_gamepad);
> +        if (sn_len && !ext->index)
> +        {
> +            swprintf(dst, len, L"%u&%x&%u&%s&%u", desc->version, desc->uid, ext->index,
> +                     desc->serialnumber, desc->is_gamepad);
> +        }
> +        else
> +        {
> +            i = 0;
> +            do
> +                swprintf(&tmp[i*2], ARRAY_SIZE(tmp) - (i * 2), L"%02X", desc->port_path[i]);
> +            while (++i < ARRAY_SIZE(desc->port_path) && desc->port_path[i]);

Could we just make port_path a UINT64? Using an array only to parse it, or does the format matter for something?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9687#note_124902