17 Oct
2022
17 Oct
'22
11:25 a.m.
Rémi Bernon (@rbernon) commented about dlls/ntdll/unix/signal_x86_64.c:
"movq %gs:0x30,%rcx\n\t" "movq 0x328(%rcx),%rcx\n\t" /* amd64_thread_data()->syscall_frame */ "popq 0x70(%rcx)\n\t" /* frame->rip */ + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") + // $rip = frame->rip // (*(0x70($rcx)))
I understand the point but I don't think we need to keep these comments. We also don't use C++-style comments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065#note_10939