27 Jul
2022
27 Jul
'22
1:13 p.m.
Giovanni Mascellani (@giomasce) commented about dlls/xactengine3_7/xact_dll.c:
return E_OUTOFMEMORY; }
- lookup = HeapAlloc(GetProcessHeap(), 0, sizeof(*lookup)); - if (!lookup) + hr = wrapper_add_entry(This, fwb, &wb->IXACT3WaveBank_iface); + if (FAILED(hr)) { FACTWaveBank_Destroy(fwb); HeapFree(GetProcessHeap(), 0, wb); ERR("Failed to allocate wrapper_lookup!\n");
There is probably little need to have this error message, given that's in the callback already. Same below and in later patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/536#note_5055