22 Dec
2024
22 Dec
'24
12:25 p.m.
On Sun Dec 22 12:25:44 2024 +0000, William Horvath wrote:
I'll have to look into the macos build failure and test it there as well. Some testing on macOS 13 showed that the check in `virtual_is_valid_code_address( instr, 1 )` leads to an early exit that breaks the fix, because the view->protect flags are missing `VPROT_SYSTEM`. I'm not sure what's causing this difference.
For the minimal test program, simply removing that `virtual_is_valid_code_address` check allows it to work, but that doesn't seem like a robust solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7064#note_91050