On Thu May 16 08:50:10 2024 +0000, Huw Davies wrote:
This looks a bit odd, given that `IAudioClockAdjustment` can be QI'ed from `IAudioClient`. We need more tests: e.g. can you QI `IAudioClient` from `IAudioClockAdjustment`? Does QI'ing `IUnknown` from `IAudioClockAdjustment` give the same result as QI'ing `IUnknown` from `IAudioClient` (as it should if it's the same object). I'm wondering whether our current `IAudioClock` implementation is correct in this regard too. `IAudioClock` is a separate thing because we get it via `GetService()`. It's impossible to get it via `QueryInterface()` from `AudioClient`. Some more test + change to `ACA_QueryInterface()` to just use `AudioClient3`'s version incoming :-)
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_70645