20 Jul
2023
20 Jul
'23
1:16 p.m.
On Thu Jul 20 11:06:29 2023 +0000, Gabriel Ivăncescu wrote:
It looks like a compiler bug to me, if I add some other patches on top (that don't touch this part at all, and without LTO of course), it magically goes away, even if I rebuild `set.c`. I can initialize it to NULL of course but, should we work around such bugs? Yeah, it is a compiler bug, but changing the code to look like this does not seem like a bad idea:
if (!(weakmap = get_weakmap_this(ctx, vthis))
return DISP_E_EXCEPTION;
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3300#note_39610