16 Feb
2024
16 Feb
'24
6:26 p.m.
Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
+{ + BYTE byte; + BYTE status, meta_event_type; + DWORD length; + LARGE_INTEGER offset; + HRESULT hr = S_OK; + DWORD delta_time; + + if ((hr = read_variable_length_number(stream, &delta_time, bytes_left)) != S_OK) return hr; + + if ((hr = stream_read_at_most(stream, &byte, 1, bytes_left)) != S_OK) return hr; + + if (byte & 0x80) + { + status = byte; + *last_status = byte; Nit: in this case as well, it's very common to use combined assignment for variables of the same type.
```suggestion:-1+0 status = *last_status = byte; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5081#note_61504