13 Jun
2023
13 Jun
'23
10:01 a.m.
On Tue Jun 13 10:01:40 2023 +0000, Zebediah Figura wrote:
I don't think we want the frontend casting logic to live or be used anywhere outside of the frontend. If we're generating instructions after parsing, they should already have the right types. I would prefer names like DISCARD_NZ and DISCARD_NEG rather than DISCARD and TEXKILL. By casting you mean deferring turning texkill to discard_nz in a first place? Or having higher level calls that do type conversion in codegen.c, like hlsl_add_binary_comparison_expr()?
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211#note_35607