On Fri Jun 2 21:03:18 2023 +0000, Francisco Casas wrote:
~~After some thought, I think that what we are missing is a pass that lowers 1D combined samples to 2D. But **only** combined samples. So we end up with something like:~~ ```c // Only 1D combined samples (with load->sampler == NULL) get converted into 2D. hlsl_transform_ir(ctx, lower_1d_combined_samples_to_2d, body, NULL); // ... if (profile->major_version >= 4) { hlsl_transform_ir(ctx, lower_tex_proj, body, NULL); } // ... if (profile->major_version >= 4) { hlsl_transform_ir(ctx, lower_combined_samples, body, NULL); // From !209 } // ... ``` ~~If we do this, you wouldn't have to worry about 1D HLSL_RESOURCE_SAMPLE_PROJ here.~~ nevermind, that is not a solution because you would end up dividing 0.5 by w anyways.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219#note_34529