Re: [PATCH v2 06/11] mciqtz32: Correct video window behavior by creating default window.

[Zebediah Figura (she/her)]

On 7/31/22 06:53, Akihiro Sagawa wrote:
> +static BOOL MCIQTZ_CreateWindow(WINE_MCIQTZ* wma, DWORD dwFlags, LPMCI_DGV_OPEN_PARMSW lpParms)
> +{
> +    HWND parent = NULL;
> +    DWORD style = (WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN) & ~WS_MAXIMIZEBOX;
> +    LONG width, height;
> +    RECT rc;
> +    HRESULT hr;
> +
> +    if (dwFlags & MCI_DGV_OPEN_PARENT)	parent = lpParms->hWndParent;
> +    if (dwFlags & MCI_DGV_OPEN_WS)	style = lpParms->dwStyle;
> +
> +    hr = IBasicVideo_GetVideoSize(wma->vidbasic, &width, &height);
> +    if (hr == E_NOINTERFACE)
> +        return TRUE; /* audio file */
> +    else if (FAILED(hr))
> +        return FALSE;
> +
> +    /* FIXME: Use video size here */
> +    width = 640;
> +    height = 480;

Since this is kind of a regression otherwise (and since patch 8/11 is 
pretty much a one-liner) I think it makes more sense just to merge that 
patch into this one. Apologies if I said the opposite last review...
> +
> +    wma->window = CreateWindowW(MCIQTZ_CLASS, lpParms->lpstrElementName, style,
> +                                CW_USEDEFAULT, CW_USEDEFAULT,
> +                                width, height,
> +                                parent, 0, MCIQTZ_hInstance,
> +                                0);