Re: [PATCH v6 0/15] MR319: vkd3d-shader: Introduce vkd3d_shader_register.dimension, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> if (!register_type_info)
>      {
>          FIXME("Unhandled register type %#x.\n", register_type);
> -        param->type = VKD3DSPR_TEMP;
> +        vsir_register_type = VKD3DSPR_TEMP;
>      }
>      else
>      {
> -        param->type = register_type_info->vkd3d_type;
> +        vsir_register_type = register_type_info->vkd3d_type;
>      }
> +
> +    vsir_register_init(param, vsir_register_type, data_type, 0);

It's mostly a matter of taste, but I find it easier to read the code if you immediately parse the index count and pass it appropriately to `vsir_register_init()`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/319#note_44393