3 Mar
2023
3 Mar
'23
9:51 a.m.
Huw Davies (@huw) commented about dlls/mmdevapi/main.c:
TRACE("Attempting to load %s\n", wine_dbgstr_w(driver_module));
- driver->module = LoadLibraryW(driver_module); - if(!driver->module){ - TRACE("Unable to load %s: %lu\n", wine_dbgstr_w(driver_module), - GetLastError()); + if (!(driver->module = LoadLibraryW(driver_module))) { + TRACE("Unable to load %s: %lu\n", wine_dbgstr_w(driver_module), GetLastError()); return FALSE;
This change seems unnecessary. Otherwise this MR looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1543#note_26085