26 Nov
2022
26 Nov
'22
1:25 a.m.
Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.h:
const char **source_files; unsigned int source_files_count; + /* Current location being read in the HLSL source, updated while parsing. */ struct vkd3d_shader_location location; + /* Stores the logging messages and logging configuration. */ struct vkd3d_shader_message_context *message_context; + /* Stores string buffers currently in use. */
This feels like it doesn't answer enough (and is kind of misleading, because buffers that are 'in use' at a given moment actually aren't in the struct). Maybe something like "cache for temporary string allocations"? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/50#note_17519