8 Jul
2025
8 Jul
'25
4:24 p.m.
Connor McAdams (@cmcadams) commented about dlls/setupapi/tests/devinst.c:
ok(size == sizeof(valueW), "Got size %ld\n", size); ok(!lstrcmpW((WCHAR *)buffer, valueW), "Expect buffer %s, got %s\n", wine_dbgstr_w(valueW), wine_dbgstr_w((WCHAR *)buffer));
+ /* #15 Innate properties */ + type = DEVPROP_TYPE_EMPTY; + size = 0; + buffer[0] = '\0';
This is a `BYTE` type buffer being used to store a wide character string return value, so I'm pretty sure what you're doing here would only set half of the character value to NULL. I think the better way to do this is to just do: ```suggestion:-0+0 memset(buffer, 0, sizeof(buffer)); ``` Like the previous test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109122