14 Sep
2023
14 Sep
'23
7:36 p.m.
On Thu Sep 14 19:36:36 2023 +0000, Rémi Bernon wrote:
ParseDescriptor is there for a reason as a lightweight info gathering. And the object is immediately destroyed afterwards. Loading the full object is excessive in that case. Of course, I didn't mean them to do the same, but the parsing code could be shared, and the chunks required only for Load would be skipped when called from ParseDescriptor. Anyway, I left the controversial parts for a later time :). Well sure, but the descriptor parsing is shared now too in both functions.
Anyway, much easier to review now without unrelated en passant changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3795#note_45375