30 Sep
2025
30 Sep
'25
2:58 a.m.
Nikolay Sivov (@nsivov) commented about dlls/mfreadwrite/writer.c:
+ HRESULT hr; + + if (FAILED(hr = IMFStreamSink_GetMediaTypeHandler(stream->stream_sink, &type_handler))) + return hr; + hr = IMFMediaTypeHandler_GetCurrentMediaType(type_handler, out_type); + + IMFMediaTypeHandler_Release(type_handler); + return hr; +} + +static HRESULT stream_create_transforms(struct stream *stream, + IMFMediaType *input_type, IMFMediaType *output_type, BOOL use_encoder) +{ + FIXME("Not implemented.\n"); + return E_NOTIMPL; +} I think a stub in method itself is enough, no need for empty helpers.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7570#note_117143