Re: [PATCH v2 0/3] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).

[Etaash Mathamsetty (＠etaash.mathamsetty)]

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/setupapi/devinst.c:
> +    {
> +        SETUPDI_GuidToString( &key->fmtid, prop_path + 11 );
> +        swprintf( prop_path + 49, ARRAY_SIZE( prop_path ) - 49, L"\\%04X", key->pid );
> +        if (!(ret = RegOpenKeyExW( iface->refstr_key, prop_path, 0, KEY_QUERY_VALUE, &property )))
> +        {
> +            size = buf_size;
> +            ret = RegQueryValueExW( property, NULL, NULL, &val_type, buf, &size );
> +            RegCloseKey( property );
> +        }
> +
> +        switch (ret)
> +        {
> +        case ERROR_SUCCESS:
> +        case ERROR_MORE_DATA:
> +            *type = val_type & 0xffff;
> +        ret = (ret == ERROR_MORE_DATA || !buf) ? ERROR_INSUFFICIENT_BUFFER : ERROR_SUCCESS;
> If it can't be refactored, you missed a indent here :p

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8379#note_107338