10 Oct
2024
10 Oct
'24
1:09 p.m.
Piotr Caban (@piotr) commented about dlls/msvcrt/tests/locale.c:
} }
+static void __cdecl test_thread_setlocale_func(void * arg __attribute__((unused))) +{ + char *ret; + + ret = setlocale(LC_ALL, NULL); + ok(!strcmp(ret, "C"), "expected ret=C, but received ret=%s\n", ret); + + ret = setlocale(LC_ALL, ""); + ok(strcmp(ret, "Invariant Language_Invariant Country.0"), "expected something different, but received ret=%s\n", ret);
Could you please change the error string to something like: `"expected valid locale\n"`? It's already known what's the value of ret if the test fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6644#note_84573