11 Nov
2025
11 Nov
'25
2:39 a.m.
On Thu Nov 6 09:19:03 2025 +0000, eric pouech wrote:
I'm not sure we want that... if an app requests say module+heaps, before we were returning success + modules (and zero heaps), with this change the call will fail perhaps we'd better just add a WARNa about unsupported flags I think failing is better than returning the wrong result. Application might have a fallback code path, but if we return incorrect result it may do something unexpected.
I made this change because it makes writing the test a bit simpler. i.e. I can check if `CreateToolhelp32Snapshot` fails and return early, and not need to bother with adding more `todo`s. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9371#note_121481