27 Sep
2023
27 Sep
'23
1:41 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
} }
+ for (i = 0; i < block->child_block_count; ++i) + { + if (block->child_blocks[i]->id == CONSTANTS_BLOCK && (ret = sm6_parser_constants_init(sm6, + block->child_blocks[i])) < 0)
Could this be splitted like this? ```c if (block->child_blocks[i]->id == CONSTANTS_BLOCK && (ret = sm6_parser_constants_init(sm6, block->child_blocks[i])) < 0) ``` It feels much easier to read to me. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372#note_46961