22 Mar
2024
22 Mar
'24
5:58 p.m.
Zebediah Figura (@zfigura) commented about dlls/ddraw/main.c:
DWORD ddraw_allocate_handle(struct ddraw_handle_table *t, void *object, enum ddraw_handle_type type) { struct ddraw_handle_entry *entry; + DWORD ret = DDRAW_INVALID_HANDLE; + + if (!t) + { + t = &global_handle_table; + wined3d_mutex_lock(); + } Sorry, what I was trying to get at in IRC is that functions that access the handle table are already going to hold the wined3d mutex. I think it'd be a bug if they didn't.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5329#note_65814