15 Jul
2025
15 Jul
'25
10:02 a.m.
Jacek Caban (@jacek) commented about dlls/urlmon/zone_id.c:
+ } + + /* FIXME: Read zone information from Zone.Identifier NTFS alternate data stream */ + + hfile = CreateFileW(file_name, GENERIC_READ, + FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, + FILE_ATTRIBUTE_NORMAL, NULL); + if (hfile == INVALID_HANDLE_VALUE) + return HRESULT_FROM_WIN32(GetLastError()); + + CloseHandle(hfile); + + if (lstrcmpW(This->load_file_name, file_name)) + { + if (This->load_file_name) + free(This->load_file_name); There is no need for the NULL check prior to `free()` call.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8459#note_109922