Re: [PATCH v7 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)

6 Nov 2025

      On Thu Nov  6 22:12:02 2025 +0000, Alexandre Julliard wrote:
...
In general we don't add NULL checks unless there's an app that depends
on them. I'm also not sure why the analyzer would complain about this.
That's because `ExecuteCabW` has the following code:
if ((pCab->pszCab && *pCab->pszCab) && (pCab->pszInf && *pCab->pszInf) && *pCab->szSrcPath)
{
   // SNIP
}

hr = install_init(pCab->pszInf, pCab->pszSection, pCab->szSrcPath, pCab->dwFlags, &info);

Which implies that `pCab->pszInf` can be NULL, but it's dereferenced in `install_init` later.
I thought I'd correct that mistake, but if you think it's fine as is, feel free to close this - there's currently no program I know of affected by it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_121110

Re: [PATCH v7 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)

Fabian Maurer (＠DarkShadow44)