Re: [PATCH 0/2] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> +static inline unsigned int shader_sm6_read_uint32(struct vkd3d_shader_parser *parser)
> +{
> +    if (shader_sm6_is_end(parser))
> +    {
> +        parser->failed = true;
> +        return 0;
> +    }
> +    return *parser->ptr++;
> +}
> +
> +static inline unsigned int shader_sm6_read_bits(struct vkd3d_shader_parser *parser, unsigned int length)
> +{
> +    unsigned int l, prev_len = 0;
> +    uint32_t bits;
> +
> +    if (!length)
> Mostly for the sake of documentation, I would add an assertion that `length < 32`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44#note_12818