22 Mar
2023
22 Mar
'23
7:55 a.m.
Rémi Bernon (@rbernon) commented about dlls/windows.ui/uisettings.c:
{ *out = &impl->IUISettings3_iface; - IInspectable_AddRef( *out ); - return S_OK; }
- FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); - *out = NULL; - return E_NOINTERFACE; + if(!*out) + { + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + return E_NOINTERFACE; + } + + IUnknown_AddRef( (IUnknown*)*out );
```suggestion:-0+0 IUnknown_AddRef( (IUnknown *)*out ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2465#note_27492