Re: [PATCH v3 0/9] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> return order;
>  }
>
> -static void write_sm4_instruction(struct vkd3d_bytecode_buffer *buffer, const struct sm4_instruction *instr)
> +static void write_sm4_instruction(struct hlsl_ctx *ctx, struct vkd3d_bytecode_buffer *buffer,

I think we usually split the "pass `ctx` to this function" part in a dedicated patch. It feels much cleaner to me.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281#note_40433