2 Sep
2022
2 Sep
'22
5:29 a.m.
Nikolay Sivov (@nsivov) commented about dlls/d2d1/effect.c:
if (!(entry = calloc(1, sizeof(*entry)))) return E_OUTOFMEMORY;
- ID2D1TransformNode_AddRef(entry->node = node); + entry->input_count = ID2D1TransformNode_GetInputCount(node); + if (!(entry->inputs = calloc(entry->input_count, sizeof(*entry->inputs)))) + { + free(entry); + return E_OUTOFMEMORY; + }
Is it possible for node input count to change? If it's constant, this array could be created on node creation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/698#note_7534