25 Jan
2024
25 Jan
'24
4:46 a.m.
Hans Leidekker (@hans) commented about dlls/winhttp/request.c:
return count; }
-static BOOL skip_async_queue( struct request *request ) +static BOOL skip_async_queue( struct request *request, BOOL *data_available ) { - return request->hdr.recursion_count < 3 && (end_of_read_data( request ) || query_data_ready( request )); + *data_available = end_of_read_data( request ) || query_data_ready( request );
It's counterintuitive that *data_available is set to true when end_of_read_data() returns true. Perhaps we can find a better name, or pull that condition out of skip_async_queue()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4925#note_58962