17 Nov
2023
17 Nov
'23
9:38 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
LIST_FOR_EACH_ENTRY(decl, &func->overloads, struct hlsl_ir_function_decl, entry) { + if (func_is_exact_match(decl, args)) + return decl;
I don't think I agree with this. I'd reject valid programs rather than miscompile invalid programs. I think it makes sense to leave your test as `todo` for now, if you (understandably) don't want to work out all the overloading rules for this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/478#note_52666