10 Oct
2024
10 Oct
'24
7:52 a.m.
Nikolay Sivov (@nsivov) commented about dlls/propsys/propvar.c:
if (!propvarIn->pwszVal) return DISP_E_TYPEMISMATCH;
- if (!lstrcmpiW(propvarIn->pwszVal, L"true") || !lstrcmpW(propvarIn->pwszVal, L"#TRUE#")) + if (!wcsicmp(propvarIn->pwszVal, L"true") || !wcscmp(propvarIn->pwszVal, L"#TRUE#")) { *ret = TRUE; return S_OK; }
- if (!lstrcmpiW(propvarIn->pwszVal, L"false") || !lstrcmpW(propvarIn->pwszVal, L"#FALSE#")) + if (!wcsicmp(propvarIn->pwszVal, L"false") || !wcscmp(propvarIn->pwszVal, L"#FALSE#"))
I don't think this achieves anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6640#note_84546