3 Apr
2025
3 Apr
'25
10:40 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
test_format_conversion(device); test_dxt_premultiplied_alpha(device); test_load_surface_from_tga(device); + test_color_key(device);
I just now realized the new test is being called from `test_D3DXLoadSurface()`. I think it would be better to get rid of one level of nesting i.e. call the new test directly from the main function, creating a separate `device` in the new test. It might make sense to add helpers like `create_device()` while at it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7711#note_99961