Re: [PATCH 0/1] MR92: vkd3d-shader/hlsl: Write SM4 break instructions.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl_sm4.c:
> +static void write_sm4_jump(struct hlsl_ctx *ctx,
> +        struct vkd3d_bytecode_buffer *buffer, const struct hlsl_ir_jump *jump)
> +{
> +    struct sm4_instruction instr = {0};
> +
> +    switch (jump->type)
> +    {
> +        case HLSL_IR_JUMP_BREAK:
> +            instr.opcode = VKD3D_SM4_OP_BREAK;
> +            break;
> +
> +        default:
> +            hlsl_fixme(ctx, &jump->node.loc, "Jump type %s.\n", hlsl_jump_type_to_string(jump->type));
> +            return;
> +    }

While we're at it I might add an unreachable case for RETURN. Doesn't need to block this patch though.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/92#note_24091