Re: [PATCH v3 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.

[Mohamad Al-Jaf (＠maljaf)]

On Wed Nov 30 08:18:57 2022 +0000, Hans Leidekker wrote:
> Please name the getter after the property: get_bios_serialnumber(). This
> can be simplified to:
> `static WCHAR *get_bios_serialnumber( const char *buf, UINT len )
> {
>     WCHAR *ret = get_bios_string( 4, buf, len );
>     if (!ret) return wcsdup( L"0" );
>     return ret;
> }
> `
> Note that on Linux this will not get a different value because serial
> numbers are readable only by root.
> Thanks for the review. Renamed and refactored it according to your suggestions. Yeah, that's true, but I suppose there's no reason not to implement it anyway.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1588#note_18201