On Wed Feb 4 16:46:25 2026 +0000, Phiality wrote:
Thanks for the review! **I** understand the preference for smaller MRs, but the reason these are together is that they're all required for WebUI-based installers (like Adobe Creative Cloud) to work in ES5+ mode, individually, none of them fix the end-user problem. **I** addressed the documentmode.js test updates in 3eba1fb9, removed XMLSerializer from the window own props todo list and added the prototype props check. I'm fine with either my CDATA wrapping approach or patching the bundled libxml2 validation as @nsivov suggested, but the installer hard-fails at 30% without a fix for this, so I don't think we should pull it out and wait for the libxml2 parser replacement to land, rather we can rip it out later when it does land. Whatever approach we go with, something needs to exist. On DISPATCH_METHOD|DISPATCH_PROPERTYGET, my fix is a different approach from what was in !10004. Gabriel's patch unconditionally treats the flag combo as `DISPATCH_METHOD`. Mine checks `cArgs > 0`, with arguments it's clearly a method call, without arguments it falls back to version-dependent behavior. The `method_reference_call` test I included is based on the exact scenario you posted in your review of !10004 that caused that patch to be dropped, and it passes with this approach. There is a misunderstanding regarding libxml2 change I suggested. I don't expect upstream to remove this check, what I suggested is to modify our local copy which is in wine tree, in libs/xml2.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10025#note_128784