I'm not sure to get your point. - do you mean that you'd like to ok() test the return values of all the calls in the helper? I didn't do it as a) the helper can be called with an inexistant file, b) the cases of failure are ok() tested later on (machine not being unknown) - do you mean the calls in the helper can't fail? (I don't see a reason they wouldn't) - something else? Le ven. 10 févr. 2023 à 19:23, Zebediah Figura (@zfigura) < wine(a)gitlab.winehq.org> a écrit :
Zebediah Figura (@zfigura) commented about dlls/dbghelp/tests/dbghelp.c:
+ { + hMap = CreateFileMappingW(hFile, NULL, PAGE_READONLY, 0, 0, NULL); + if (hMap != NULL) + { + mapping = MapViewOfFile(hMap, FILE_MAP_READ, 0, 0, 0); + if (mapping != NULL) + { + nthdr = RtlImageNtHeader(mapping); + if (nthdr != NULL) machine = nthdr->FileHeader.Machine; + UnmapViewOfFile(mapping); + } + CloseHandle(hMap); + } + CloseHandle(hFile); + } return machine; Why do this? This part doesn't fail.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2152#note_23766