23 Jan
2023
23 Jan
'23
1:47 a.m.
Jinoh Kang (@iamahuman) commented about dlls/windows.media.speech/recognizer.c:
+ } + else + hr = COR_E_INVALIDOPERATION; + LeaveCriticalSection(&impl->cs); + + if (SUCCEEDED(hr)) + { + SetEvent(impl->worker_control_event); + WaitForSingleObject(thread, INFINITE); + CloseHandle(thread); + + EnterCriticalSection(&impl->cs); + impl->worker_thread = NULL; + LeaveCriticalSection(&impl->cs); + } + else if (FAILED(hr))
if (FAILED(hr))
No need to chain as `else if`. You can leave the last `if` isolated for consistency with other functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1948#note_21376