Re: [PATCH 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/volume.c:
> {
>      HRESULT hr;
>      D3DBOX src_box;
> +    uint32_t x, y, z;
> +    D3DVOLUME_DESC desc;
> +    D3DXIMAGE_INFO img_info;
>      IDirect3DVolume9 *volume;
> +    struct volume_readback volume_rb;
>      IDirect3DVolumeTexture9 *volume_texture;
> +    static const uint32_t bmp_32bpp_4_4_argb_expected[] =
> +    {
> +        0xffff0000, 0xff00ff00, 0xff0000ff, 0xff000000,
> +    };
> Just for future endeavors: I think it's better to consistently order declarations the other way around, from the longest line to the shortest. That's what we generally do for new "d3d" code.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5881#note_74665