Re: [PATCH v6 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/shlwapi/tests/url.c:
> ok(strcmp(szReturnUrl,"")==0, "Expected empty string\n");
>      }
>
> +    unescaped = INTERNET_MAX_URL_LENGTH;
> +    lstrcpyW(urlW, L"%F0%9F%8D%B7");
> +    res = UrlUnescapeW(urlW, NULL, &unescaped, URL_UNESCAPE_AS_UTF8 | URL_UNESCAPE_INPLACE);
> +    ok(res == S_OK, "Got %#lx.\n", res);
> +    if (!wcscmp(urlW, L"\xf0\x9f\x8d\xb7"))
> +        utf8_support = FALSE;
> +
>      for (i = 0; i < ARRAYSIZE(TEST_URL_UNESCAPEW); i++)
>      {
> +        if (TEST_URL_UNESCAPEW[i].flags | URL_UNESCAPE_AS_UTF8 && !utf8_support)

The flag check does not look right.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/585#note_41352