Re: [PATCH 0/6] MR844: win32u: Move display modes enumeration and WM_DISPLAYCHANGE out of graphics drivers.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c:
> if (!lock_display_devices()) return DISP_CHANGE_FAILED;
>      adapter = find_adapter( devname );
>      unlock_display_devices();
> -    if (!adapter)
> -    {
> -        WARN( "Invalid device name %s.\n", debugstr_us(devname) );
> -        return DISP_CHANGE_BADPARAM;
> -    }
> +    if (!adapter) return DISP_CHANGE_BADPARAM;

Why do you remove the WARN()? same for the following. If you don't want to trace the failure in the callers, you can add the trace in find_adapter() instead.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/844#note_8467