11 Nov
2022
11 Nov
'22
12:26 a.m.
Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c:
stream->number = number; stream->reader = reader; list_init(&stream->read_samples); + list_init(&stream->deliver_samples);
if (!(stream->read_thread = CreateThread(NULL, 0, stream_read_thread, stream, 0, NULL))) return E_OUTOFMEMORY;
+ if (!(stream->deliver_thread = CreateThread(NULL, 0, stream_deliver_thread, stream, 0, NULL))) + { + stream_close(stream); + return E_OUTOFMEMORY; + } +
Why are we using a separate delivery thread, instead of reusing read_thread? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_14011