20 Sep
2022
20 Sep
'22
9:48 a.m.
On Tue Sep 20 14:35:46 2022 +0000, Santino Mazza wrote:
But as I understand, if we can use strlen in unix_name, that means its a null terminated string and wine_server_add_data should append data to the server request including the null terminator, becuase of strlen( unix_name ) + 1. So in the server side we should receive that null terminator when using get_req_data_after_objattr. (sorry replied to the wrong thread earlier)
The point is that the server shouldn't assume that the client has correctly nul-terminated the string (to guard against a wayward client). That being the case, there's no point in sending the '\\0' in the first place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8900