Re: [PATCH 0/2] MR8293: kernelbase: SetFileInformationByHandle pass FileRenameInfoEx to NtSetInformationFile

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/kernelbase/tests/file.c:
> todo_wine ok(hr == S_OK, "got %#lx.\n", hr);
>  }
>
> +static void test_SetFileInformationByHandle(void)
> +{
> +    HANDLE handle;
> +    static const WCHAR filename1[] = L"test1";
> +    static const WCHAR filename2[] = L"test2";
> +    static const WCHAR filename3[] = L"test3";
> +    BOOL success;
> +    FILE_RENAME_INFO* renameinfo;
> +    size_t renameinfo_sz;
> +    FILE_RENAME_INFO* renameinfoex;
> +    size_t renameinfoex_sz;
> +
> +    if (!pQueryIoRingCapabilities)

What does ioring have to do with FileRenameInfoEx? Even if it happens to be introduced on the right Windows version, it still looks weird.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8293#note_106316