Re: [PATCH 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/winex11.drv/xrandr.c:
> }
>              RtlUTF8ToUnicodeN( gpu->name, sizeof(gpu->name), &len, properties2.properties.deviceName,
>                                 strlen( properties2.properties.deviceName ) + 1 );
> +
> +            pvkGetPhysicalDeviceMemoryProperties( vk_physical_devices[device_idx], &mem_properties );
> +            for (heap_idx = 0; heap_idx < mem_properties.memoryHeapCount; heap_idx++)
> +            {
> +                if (mem_properties.memoryHeaps[heap_idx].flags & VK_MEMORY_HEAP_DEVICE_LOCAL_BIT)
> +                {
> +                    gpu->memory_size = mem_properties.memoryHeaps[heap_idx].size;
> +                    break;

I think you should add all heap sizes with VK_MEMORY_HEAP_DEVICE_LOCAL_BIT together instead of breaking at the first heap with the flag.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4466#note_53255