Re: [PATCH v4 0/13] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> return D3D_SVC_MATRIX_COLUMNS;
>              else
>                  return D3D_SVC_MATRIX_ROWS;
> -        case HLSL_CLASS_OBJECT:
> -            return D3D_SVC_OBJECT;
>          case HLSL_CLASS_SCALAR:
>              return D3D_SVC_SCALAR;
>          case HLSL_CLASS_STRUCT:
>              return D3D_SVC_STRUCT;
>          case HLSL_CLASS_VECTOR:
>              return D3D_SVC_VECTOR;
> -        default:
> -            ERR("Invalid class %#x.\n", type->class);
> -            vkd3d_unreachable();
> +        case HLSL_CLASS_OBJECT:
> +            break;

Not that I care that much, but I'd claim that the standard construct is `case XXX: vkd3d_unreachable();` rather than breaking and then calling `vkd3d_unreachable()`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/626#note_61858