31 Jul
2025
31 Jul
'25
7:23 p.m.
Nikolay Sivov (@nsivov) commented about dlls/cryptowinrt/main.c:
static HRESULT STDMETHODCALLTYPE cryptobuffer_statics_EncodeToBase64String( ICryptographicBufferStatics *iface, IBuffer *buffer, HSTRING *value) { + UINT32 len = 0; + FIXME("iface %p, buffer %p, value %p stub!\n", iface, buffer, value);
+ if (buffer) IBuffer_get_Length( buffer, &len ); + + if (!buffer || !len) return WindowsCreateString( NULL, 0, value ); You don't need to check for null buffer, length check is enough.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111742